[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 125331: Port part of KCalUtils::IncidenceFormatter to Grantlee template
From: Daniel_Vrátil <dvratil () kde ! org>
Date: 2015-10-05 16:41:24
Message-ID: 20151005164124.17685.78849 () mimi ! kde ! org
[Download RAW message or body]
> On Oct. 5, 2015, 5:39 p.m., Sandro Knauß wrote:
> > src/grantlee_plugin/icon.cpp, line 116
> > <https://git.reviewboard.kde.org/r/125331/diff/6/?file=409222#file409222line116>
> >
> > add a "alt" propery for screenreader or people who can't look pictures.
Yeah, but what should the alt say? We only know the filename, nothing about the \
content...
> On Oct. 5, 2015, 5:39 p.m., Sandro Knauß wrote:
> > src/incidenceformatter.cpp, line 1076
> > <https://git.reviewboard.kde.org/r/125331/diff/6/?file=409229#file409229line1076>
> >
> > why do you need to differ between oneday one multiday Freebusy here? for \
> > todo/events it was not needed
There's a differente in representation, so multiday FB says "2015-10-04 10:00:00 - \
2015-10-05 12:00:00", while single-day FB says "2015-10-04, 10:00:00 - 12:00:00". \
Events always show the full datetime AFAIK.
This is 1:1 port from the original code.
> On Oct. 5, 2015, 5:39 p.m., Sandro Knauß wrote:
> > src/incidenceformatter.cpp, line 337
> > <https://git.reviewboard.kde.org/r/125331/diff/6/?file=409229#file409229line337>
> >
> > for kolab we also need delegator/delegatee for persons. This is done by adding a \
> > indetity of that other person -> so that not everytime you find a identity of a \
> > person means that it is you (as person). And you may want to mail the delegatee.
> > I would recommend to add the mail in anycase ( if available) and push the \
> > decision, if you want to display the mailto url further up the stack.
> > That makes it much more easier to implement delegator/delegatee support properly.
That's for ITIP though, not for events/todos, right?
Additionally, "thatIsMe" is always correct, you never want to mail yourself, right? \
The email address is resolved against KIdentityManagement::thatIsMe(), so if the even \
is delegated, the email address is different and we display it correctly.
This only really supresses a clickable email if the email address matches any of your \
KMail identities.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125331/#review86382
-----------------------------------------------------------
On Oct. 1, 2015, 10:21 a.m., Daniel Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125331/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 10:21 a.m.)
>
>
> Review request for KDEPIM, Laurent Montel and Volker Krause.
>
>
> Repository: kcalutils
>
>
> Description
> -------
>
> I needed to extend the HTML generated for todos so that it includes some more \
> fields useful for the Phabricator resource. After digging around the code a bit a \
> decided to see if I can port it to Grantlee, which is way easier to maintain and \
> modify and also provides much cleaner separation between logic and representation \
> and this is the result of it :)
> This patch does not port the entire IndicendeFormatter to Grantlee, only events, \
> tasks, journals and free/busy, I haven't touched the ITIP formatter yet.
> The new code works just fine, but I consider it more of a proof-of-concept than a \
> ready-to-ship patch and I'd like to get your input regarding the use of Grantlee - \
> should we use a QObject wrapper for KCalCore::Incidence instead of QVariantHash, or \
> maybe use the Grantlee MetaType system directly for thinner-than-QObject wrappers, \
> should we use the custom Grantlee plugin, ...?
> Also please see the mail on kde-pim regarding where should we put the plugin :)
>
>
> Diffs
> -----
>
> CMakeLists.txt d145b6a
> Messages.sh PRE-CREATION
> autotests/CMakeLists.txt a7ce2f1
> autotests/data/event-1.html PRE-CREATION
> autotests/data/event-1.ical PRE-CREATION
> autotests/data/event-2.html PRE-CREATION
> autotests/data/event-2.ical PRE-CREATION
> autotests/data/freebusy-1.html PRE-CREATION
> autotests/data/freebusy-1.ical PRE-CREATION
> autotests/data/journal-1.html PRE-CREATION
> autotests/data/journal-1.ical PRE-CREATION
> autotests/data/todo-1.html PRE-CREATION
> autotests/data/todo-1.ical PRE-CREATION
> autotests/testincidenceformatter.h 0065745
> autotests/testincidenceformatter.cpp 28dd952
> scripts/extract_strings_ki18n.py PRE-CREATION
> scripts/grantlee_strings_extractor.py PRE-CREATION
> src/CMakeLists.txt 0d7bdcc
> src/Messages.sh 5f5de62
> src/grantlee_plugin/CMakeLists.txt PRE-CREATION
> src/grantlee_plugin/datetimefilters.h PRE-CREATION
> src/grantlee_plugin/datetimefilters.cpp PRE-CREATION
> src/grantlee_plugin/icon.h PRE-CREATION
> src/grantlee_plugin/icon.cpp PRE-CREATION
> src/grantlee_plugin/kcalendargrantleeplugin.h PRE-CREATION
> src/grantlee_plugin/kcalendargrantleeplugin.cpp PRE-CREATION
> src/grantleeki18nlocalizer.cpp PRE-CREATION
> src/grantleeki18nlocalizer_p.h PRE-CREATION
> src/grantleetemplatemanager.cpp PRE-CREATION
> src/grantleetemplatemanager_p.h PRE-CREATION
> src/incidenceformatter.cpp c58e961
> templates/CMakeLists.txt PRE-CREATION
> templates/attendee_row.html PRE-CREATION
> templates/event.html PRE-CREATION
> templates/freebusy.html PRE-CREATION
> templates/incidence_header.html PRE-CREATION
> templates/journal.html PRE-CREATION
> templates/template_base.html PRE-CREATION
> templates/todo.html PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125331/diff/
>
>
> Testing
> -------
>
> I can see my events.
>
>
> Thanks,
>
> Daniel Vrátil
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic