[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 125331: Port part of KCalUtils::IncidenceFormatter to Grantlee template
From:       Daniel_Vrátil <dvratil () kde ! org>
Date:       2015-09-30 13:47:56
Message-ID: 20150930134756.16344.24020 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125331/
-----------------------------------------------------------

(Updated Zář. 30, 2015, 3:47 odp.)


Review request for KDEPIM, Laurent Montel and Volker Krause.


Changes
-------

The idea of this patch was to simplify the code, so far I just keep adding more stuff \
:DD

Anyway, this implements kdate,ktime and kdatetime filters so we can perform string \
conversion from Grantlee template directly (we can eventually kill the C++ methods in \
IncidenceFormatter and move their code the plugin), adds message extraction (those \
scripts should eventually go to the KGrantleePlugin repository, or whatever we come \
up with), and fixes the templates to be valid strict XHTML (I know XHTML is ugly, but \
xmllint insist on inserting <?xml ...> at the top of the linted file ...) :)


Repository: kcalutils


Description
-------

I needed to extend the HTML generated for todos so that it includes some more fields \
useful for the Phabricator resource. After digging around the code a bit a decided to \
see if I can port it to Grantlee, which is way easier to maintain and modify and also \
provides much cleaner separation between logic and representation and this is the \
result of it :)

This patch does not port the entire IndicendeFormatter to Grantlee, only events, \
tasks, journals and free/busy, I haven't touched the ITIP formatter yet.

The new code works just fine, but I consider it more of a proof-of-concept than a \
ready-to-ship patch and I'd like to get your input regarding the use of Grantlee - \
should we use a QObject wrapper for KCalCore::Incidence instead of QVariantHash, or \
maybe use the Grantlee MetaType system directly for thinner-than-QObject wrappers, \
should we use the custom Grantlee plugin, ...?

Also please see the mail on kde-pim regarding where should we put the plugin :)


Diffs (updated)
-----

  CMakeLists.txt d145b6a 
  Messages.sh PRE-CREATION 
  autotests/CMakeLists.txt a7ce2f1 
  autotests/data/event-1.html PRE-CREATION 
  autotests/data/event-1.ical PRE-CREATION 
  autotests/data/event-2.html PRE-CREATION 
  autotests/data/event-2.ical PRE-CREATION 
  autotests/data/freebusy-1.html PRE-CREATION 
  autotests/data/freebusy-1.ical PRE-CREATION 
  autotests/data/journal-1.html PRE-CREATION 
  autotests/data/journal-1.ical PRE-CREATION 
  autotests/data/todo-1.html PRE-CREATION 
  autotests/data/todo-1.ical PRE-CREATION 
  autotests/testincidenceformatter.h 0065745 
  autotests/testincidenceformatter.cpp 28dd952 
  scripts/extract_strings_ki18n.py PRE-CREATION 
  scripts/grantlee_strings_extractor.py PRE-CREATION 
  src/CMakeLists.txt 0d7bdcc 
  src/Messages.sh 5f5de62 
  src/grantlee_plugin/CMakeLists.txt PRE-CREATION 
  src/grantlee_plugin/datetimefilters.h PRE-CREATION 
  src/grantlee_plugin/datetimefilters.cpp PRE-CREATION 
  src/grantlee_plugin/icon.h PRE-CREATION 
  src/grantlee_plugin/icon.cpp PRE-CREATION 
  src/grantlee_plugin/kcalendargrantleeplugin.h PRE-CREATION 
  src/grantlee_plugin/kcalendargrantleeplugin.cpp PRE-CREATION 
  src/grantleeki18nlocalizer.cpp PRE-CREATION 
  src/grantleeki18nlocalizer_p.h PRE-CREATION 
  src/grantleetemplatemanager.cpp PRE-CREATION 
  src/grantleetemplatemanager_p.h PRE-CREATION 
  src/incidenceformatter.cpp c58e961 
  templates/CMakeLists.txt PRE-CREATION 
  templates/attendee_row.html PRE-CREATION 
  templates/event.html PRE-CREATION 
  templates/freebusy.html PRE-CREATION 
  templates/incidence_header.html PRE-CREATION 
  templates/journal.html PRE-CREATION 
  templates/template_base.html PRE-CREATION 
  templates/todo.html PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125331/diff/


Testing
-------

I can see my events.


Thanks,

Daniel Vrátil

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]