[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 125426: Check response content size for search job in kimap
From: "Allen Winter" <winter () kde ! org>
Date: 2015-09-27 19:14:07
Message-ID: 20150927191407.14939.21755 () mimi ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125426/#review86020
-----------------------------------------------------------
Ship it!
looks good to me. I have a local patch similar to this in my KDE 4.14 sources. don't know why I never \
committed it.
- Allen Winter
On Sept. 27, 2015, 6:27 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125426/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2015, 6:27 p.m.)
>
>
> Review request for Akonadi and Laurent Montel.
>
>
> Bugs: 351850
> https://bugs.kde.org/show_bug.cgi?id=351850
>
>
> Repository: kimap
>
>
> Description
> -------
>
> Bug shows that toString is being called against a null pointer, which possible because of \
> response.content does not have enough element inside it. I also occasionally hit this on kimap 15.08.1. \
> I checked some other jobs in the same folder. It seems that other jobs do check the \
> response.content.size() before look into it, so this may help fix the issue.
>
> Diffs
> -----
>
> src/searchjob.cpp 93cbfb2
>
> Diff: https://git.reviewboard.kde.org/r/125426/diff/
>
>
> Testing
> -------
>
> Compiles.
>
>
> Thanks,
>
> Xuetian Weng
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic