[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 125364: Fix heap-use-after-free in ICalFormatImpl::readICalDateTime
From: "Volker Krause" <vkrause () kde ! org>
Date: 2015-09-23 18:50:05
Message-ID: 20150923185005.14939.99636 () mimi ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125364/#review85842
-----------------------------------------------------------
Ship it!
Looks good to me.
- Volker Krause
On Sept. 23, 2015, 4:57 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125364/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 4:57 p.m.)
>
>
> Review request for KDEPIM-Libraries and Laurent Montel.
>
>
> Repository: kcalcore
>
>
> Description
> -------
>
> tzid = parts.first().toAscii(); was assigning the temporary const char * to tzid \
> that was invalid on the next line, so instead of keeping a const char * keep a \
> QByteArray
> https://build.kde.org/job/kcalcore%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Li \
> nux,compiler=gcc/lastCompletedBuild/testReport/%28root%29/TestSuite/testreadrecurrenceid/
>
>
> Diffs
> -----
>
> src/icalformat_p.cpp 6db5714
>
> Diff: https://git.reviewboard.kde.org/r/125364/diff/
>
>
> Testing
> -------
>
> valgrind doesn't complain anymore
>
>
> Thanks,
>
> Albert Astals Cid
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic