[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 125331: Port part of KCalUtils::IncidenceFormatter to Grantlee template
From:       Daniel_Vrátil <dvratil () kde ! org>
Date:       2015-09-22 11:36:56
Message-ID: 20150922113656.14939.88476 () mimi ! kde ! org
[Download RAW message or body]



> On Sept. 21, 2015, 9:06 a.m., Laurent Montel wrote:
> > src/grantleeki18nlocalizer.cpp, line 76
> > <https://git.reviewboard.kde.org/r/125331/diff/1/?file=404880#file404880line76>
> > 
> > {...} is C++11 ?

Yes, `{ ... }` is the list initialization introduced in C++11: \
http://en.cppreference.com/w/cpp/language/list_initialization. Some Qt classes have \
an implicit constructor overload that takes `std::initializer_list<T>`, which is what \
`{ ... }` is always converted to. It should be slightly more effective than doing \
`QStringList() << currentLocale()`, but more importantly it's shorter and easier to \
read (IMO) :)


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125331/#review85709
-----------------------------------------------------------


On Sept. 20, 2015, 11:48 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125331/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2015, 11:48 p.m.)
> 
> 
> Review request for KDEPIM, Laurent Montel and Volker Krause.
> 
> 
> Repository: kcalutils
> 
> 
> Description
> -------
> 
> I needed to extend the HTML generated for todos so that it includes some more \
> fields useful for the Phabricator resource. After digging around the code a bit a \
> decided to see if I can port it to Grantlee, which is way easier to maintain and \
> modify and also provides much cleaner separation between logic and representation \
> and this is the result of it :) 
> This patch does not port the entire IndicendeFormatter to Grantlee, only events, \
> tasks, journals and free/busy, I haven't touched the ITIP formatter yet. 
> The new code works just fine, but I consider it more of a proof-of-concept than a \
> ready-to-ship patch and I'd like to get your input regarding the use of Grantlee - \
> should we use a QObject wrapper for KCalCore::Incidence instead of QVariantHash, or \
> maybe use the Grantlee MetaType system directly for thinner-than-QObject wrappers, \
> should we use the custom Grantlee plugin, ...? 
> Also please see the mail on kde-pim regarding where should we put the plugin :)
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt d145b6a 
> src/CMakeLists.txt 0d7bdcc 
> src/grantlee_plugin/CMakeLists.txt PRE-CREATION 
> src/grantlee_plugin/icon.h PRE-CREATION 
> src/grantlee_plugin/icon.cpp PRE-CREATION 
> src/grantlee_plugin/kcalendargrantleeplugin.h PRE-CREATION 
> src/grantlee_plugin/kcalendargrantleeplugin.cpp PRE-CREATION 
> src/grantleeki18nlocalizer.cpp PRE-CREATION 
> src/grantleeki18nlocalizer_p.h PRE-CREATION 
> src/grantleetemplatemanager.cpp PRE-CREATION 
> src/grantleetemplatemanager_p.h PRE-CREATION 
> src/incidenceformatter.cpp 36b9fe5 
> templates/CMakeLists.txt PRE-CREATION 
> templates/attendee_row.html PRE-CREATION 
> templates/event.html PRE-CREATION 
> templates/freebusy.html PRE-CREATION 
> templates/incidence_header.html PRE-CREATION 
> templates/journal.html PRE-CREATION 
> templates/template_base.html PRE-CREATION 
> templates/todo.html PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125331/diff/
> 
> 
> Testing
> -------
> 
> I can see my events.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]