[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 125331: Port part of KCalUtils::IncidenceFormatter to Grantlee template
From:       Daniel_Vrátil <dvratil () kde ! org>
Date:       2015-09-20 21:57:56
Message-ID: 20150920215756.14939.48679 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125331/#review85704
-----------------------------------------------------------



src/grantleeki18nlocalizer.cpp (line 2)
<https://git.reviewboard.kde.org/r/125331/#comment59213>

    This shouldn't be there



src/grantleetemplatemanager.cpp (line 40)
<https://git.reviewboard.kde.org/r/125331/#comment59214>

    The `kcalendar` directory is subject to discussion if anyone has a better idea. \
Since the libraries however are called KCalendarCore and KCalendarUtils, `kcalendar` \
sounded like a good idea...



src/incidenceformatter.cpp (line 622)
<https://git.reviewboard.kde.org/r/125331/#comment59215>

    Although support for comments in todos was the original trigger for this patch, I \
decided not to add any new features/changes to the code and make it a strict port. \
Once the patch is in, I'll add whatever functionality I'm missing.  
    TODO: should probably put the comment back...



src/incidenceformatter.cpp (line 625)
<https://git.reviewboard.kde.org/r/125331/#comment59216>

    Oops, missed this one.
    
    There is a lot duplication between all the incidences, I should probably move \
such code to the incidenceTemplateHeader() function, which originally only generated \
the icons and title HTML, but can do much more now that we don't care about \
particular order in which we generate the data.


- Daniel Vrátil


On Sept. 20, 2015, 11:48 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125331/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2015, 11:48 p.m.)
> 
> 
> Review request for KDEPIM, Laurent Montel and Volker Krause.
> 
> 
> Repository: kcalutils
> 
> 
> Description
> -------
> 
> I needed to extend the HTML generated for todos so that it includes some more \
> fields useful for the Phabricator resource. After digging around the code a bit a \
> decided to see if I can port it to Grantlee, which is way easier to maintain and \
> modify and also provides much cleaner separation between logic and representation \
> and this is the result of it :) 
> This patch does not port the entire IndicendeFormatter to Grantlee, only events, \
> tasks, journals and free/busy, I haven't touched the ITIP formatter yet. 
> The new code works just fine, but I consider it more of a proof-of-concept than a \
> ready-to-ship patch and I'd like to get your input regarding the use of Grantlee - \
> should we use a QObject wrapper for KCalCore::Incidence instead of QVariantHash, or \
> maybe use the Grantlee MetaType system directly for thinner-than-QObject wrappers, \
> should we use the custom Grantlee plugin, ...? 
> Also please see the mail on kde-pim regarding where should we put the plugin :)
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt d145b6a 
> src/CMakeLists.txt 0d7bdcc 
> src/grantlee_plugin/CMakeLists.txt PRE-CREATION 
> src/grantlee_plugin/icon.h PRE-CREATION 
> src/grantlee_plugin/icon.cpp PRE-CREATION 
> src/grantlee_plugin/kcalendargrantleeplugin.h PRE-CREATION 
> src/grantlee_plugin/kcalendargrantleeplugin.cpp PRE-CREATION 
> src/grantleeki18nlocalizer.cpp PRE-CREATION 
> src/grantleeki18nlocalizer_p.h PRE-CREATION 
> src/grantleetemplatemanager.cpp PRE-CREATION 
> src/grantleetemplatemanager_p.h PRE-CREATION 
> src/incidenceformatter.cpp 36b9fe5 
> templates/CMakeLists.txt PRE-CREATION 
> templates/attendee_row.html PRE-CREATION 
> templates/event.html PRE-CREATION 
> templates/freebusy.html PRE-CREATION 
> templates/incidence_header.html PRE-CREATION 
> templates/journal.html PRE-CREATION 
> templates/template_base.html PRE-CREATION 
> templates/todo.html PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125331/diff/
> 
> 
> Testing
> -------
> 
> I can see my events.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]