[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 125049: Kleo: Port certificatedetailsdialog to QDialog
From:       "Andre Heinecke" <aheinecke () intevation ! de>
Date:       2015-09-07 8:48:12
Message-ID: 20150907084812.18618.21271 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125049/
-----------------------------------------------------------

(Updated Sept. 7, 2015, 8:48 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM.


Changes
-------

Submitted with commit 893c9f102d3022e8ae1fbd700ed9a14c25d5e033 by Andre Heinecke to \
branch master.


Repository: kdepim


Description
-------

Behavioral difference is that the old Help / Close icons are now no longer shown.

I'm a bit unsure if we should not just remove the help button there. The help has no \
specific entry about the certificatedetailsdialog. So this just opens kleopatras \
general help.


Diffs
-----

  kleopatra/dialogs/certificatedetailsdialog.h 7609a09 
  kleopatra/dialogs/certificatedetailsdialog.cpp 8ee935c 

Diff: https://git.reviewboard.kde.org/r/125049/diff/


Testing
-------

Confirmed that Dialog / Help still works.


Thanks,

Andre Heinecke

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]