[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 124987: Avoid mimeType not emitted warnings with kio_pop3
From:       "Volker Krause" <vkrause () kde ! org>
Date:       2015-09-05 13:08:47
Message-ID: 20150905130847.10622.63299 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124987/#review84866
-----------------------------------------------------------

Ship it!


Looks good to me, thanks!

- Volker Krause


On Aug. 29, 2015, 10:11 p.m., Michael Pyne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124987/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 10:11 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Several of the POP3 commands in the POP3 kioslave return their data without \
> emitting a mimetype, which leads to annoying warnings in the console output. 
> 2 of the commands (LIST and UIDL) just return a list of messages and their \
> sizes/IDs; for these I simply gave them a text/plain and went about my day, though \
> there may be something more appropriate. 
> The final command giving a warning (RETR %1) seems to be a bug in the akonadi_pop3 \
> resource, where the resource asks for a message download without giving the ID. I \
> have a separate patch to correct that. With that said, the bug is still a POP3 \
> error so we check for that and bail out in that case, instead of sending an empty \
> QByteArray() just to call finished(). 
> I know "no one uses POP3 anymore" but this would help me out at least. :)
> 
> 
> Diffs
> -----
> 
> kioslave/pop3/pop3.cpp 2073095 
> 
> Diff: https://git.reviewboard.kde.org/r/124987/diff/
> 
> 
> Testing
> -------
> 
> Have received a normal amount of emails with the patch applied, am able to move \
> messages, etc. So things look like they're working, though it's certainly possible \
> I've missed something. 
> 
> Thanks,
> 
> Michael Pyne
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]