[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 125047: Kleo: Fix tabbar context menu
From:       "Volker Krause" <vkrause () kde ! org>
Date:       2015-09-04 15:56:34
Message-ID: 20150904155634.10622.886 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125047/#review84835
-----------------------------------------------------------

Ship it!


Looks good to me. 

Lambda receivers are fine, usually it's recommended to use the 4 argument connect() \
for them as well, to limit the connection lifetime to whatever they capture, but the \
sender has the same lifetime as the capture here, so not a problem.

- Volker Krause


On Sept. 4, 2015, 1:42 p.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125047/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 1:42 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I accidentally broke the contextmenu by changing from KTabWidget to QTabWidget.
> 
> I've had trouble using the new style connect syntax with a private slot so I've \
> used a lambda instead. Hope that's ok. 
> 
> Diffs
> -----
> 
> kleopatra/view/tabwidget.h 768a5dc 
> kleopatra/view/tabwidget.cpp d5448a7 
> 
> Diff: https://git.reviewboard.kde.org/r/125047/diff/
> 
> 
> Testing
> -------
> 
> Compiles, context menu works.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]