[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 124952: libkleo: Port cryptoconfigdialog to QDialog
From:       "Volker Krause" <vkrause () kde ! org>
Date:       2015-08-27 18:39:42
Message-ID: 20150827183942.4103.69088 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124952/#review84485
-----------------------------------------------------------



libkleo/ui/cryptoconfigmodule.cpp (line 917)
<https://git.reviewboard.kde.org/r/124952/#comment58483>

    static is correct here, same as in C it makes it internal to the translation \
unit.


- Volker Krause


On Aug. 27, 2015, 6:37 p.m., Andre Heinecke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124952/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 6:37 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> This is the last remaining usage of KDialog in libkleo
> 
> Minor functionality change is that a read only Keyserver widget now behaves the \
> same as the ldap dialog with regards to shown buttons. 
> 
> Diffs
> -----
> 
> libkleo/ui/cryptoconfigmodule.cpp be4f84d 
> 
> Diff: https://git.reviewboard.kde.org/r/124952/diff/
> 
> 
> Testing
> -------
> 
> Compiles, tried out both.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]