[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: [Kde-pim] Review Request 124175: Do not try to get audit log for erroneous contexts
From: "Andre Heinecke" <aheinecke () intevation ! de>
Date: 2015-06-25 13:57:07
Message-ID: 20150625135707.20764.95337 () mimi ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124175/
-----------------------------------------------------------
Review request for KDEPIM.
Bugs: 347856
http://bugs.kde.org/show_bug.cgi?id=347856
Repository: kdepim
Description
-------
On error gpgme closes the assuan context of the gpgme context.
Calling getAuditLog on a closed context leads to a crash. (At least with gpgme 1.5.5)
It's likely that previous versions of gpgme handled this more gracefully. But the behavior is undefined.
Diffs
-----
libkleo/backends/qgpgme/threadedjobmixin.cpp b48c2d1f49c1e115b9183623da0ae34a0720a627
Diff: https://git.reviewboard.kde.org/r/124175/diff/
Testing
-------
Looking at an S/MIME Encrypted mail for which I did not have the key triggered this reliably.
The crash can also be reproduced by canceling the pinentry dialog when decrypting an S/MIME mail.
Thanks,
Andre Heinecke
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic