[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 123560: kolabchanges: messageviewer [2/4]
From: "Laurent Montel" <montel () kde ! org>
Date: 2015-04-29 12:11:01
Message-ID: 20150429121101.21733.6140 () mimi ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123560/#review79671
-----------------------------------------------------------
messageviewer/job/createeventjob.cpp (line 30)
<https://git.reviewboard.kde.org/r/123560/#comment54502>
Duplicate ?
messageviewer/job/createnotejob.h (line 36)
<https://git.reviewboard.kde.org/r/123560/#comment54503>
Q_NULLPTR as usual
messageviewer/job/createnotejob.cpp (line 78)
<https://git.reviewboard.kde.org/r/123560/#comment54504>
qCDebug
- Laurent Montel
On avr. 29, 2015, midi, Sandro Knauß wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123560/
> -----------------------------------------------------------
>
> (Updated avr. 29, 2015, midi)
>
>
> Review request for KDEPIM and Laurent Montel.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> * create notes from email
> * show close instead of cancel
>
>
> Diffs
> -----
>
> messageviewer/job/createeventjob.h e543b8197bc2e7739ed69077e0c39338ae81f342
> messageviewer/job/createeventjob.cpp 4c8c182f6d2c7f27e564c55d8b6b69f007a04198
> messageviewer/job/createnotejob.h PRE-CREATION
> messageviewer/job/createnotejob.cpp PRE-CREATION
> messageviewer/job/createtodojob.h 921290f4c99b65b1e0351b3f05183ed47b8c00b4
> messageviewer/job/createtodojob.cpp f8947424b63cfa537cc089fa6a6a4b056097e2b5
>
> Diff: https://git.reviewboard.kde.org/r/123560/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sandro Knauß
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic