[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 123509: Fix no-op line in template parser
From: "Laurent Montel" <montel () kde ! org>
Date: 2015-04-26 19:02:25
Message-ID: 20150426190225.14758.4819 () mimi ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123509/#review79537
-----------------------------------------------------------
Oh great !
But this bug exists in 4.14 too.
I will investigate it in 4.14 before it.
I will create an unittest for it.
Thanks for signal me this bug.
Regards.
- Laurent Montel
On avr. 26, 2015, 6:52 après-midi, Sergio Luis Martins wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123509/
> -----------------------------------------------------------
>
> (Updated avr. 26, 2015, 6:52 après-midi)
>
>
> Review request for KDEPIM and Laurent Montel.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> Fix no-op line, toHtmlEscaped() is const, it doesn't alter the object.
> Didn't do any testing, so I'm putting this in review board. I don't have a working \
> setup today, but this seems like low hanging fruit.
>
> Diffs
> -----
>
> templateparser/templateparser.cpp 20e740a
>
> Diff: https://git.reviewboard.kde.org/r/123509/diff/
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Sergio Luis Martins
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic