[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 123366: Create only valid QDateTime's.
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2015-04-15 14:38:27
Message-ID: 20150415143827.4623.2114 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123366/
-----------------------------------------------------------

(Updated April 15, 2015, 2:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries and Laurent Montel.


Repository: kcontacts


Description
-------

Create only valid QDateTime's.

With an invalid QTime aka QTime() the QDateTime is also invalid. This
hack was used to have something like a QDateTime with a dateonly feature.

With this patch we no longer create invalid date-times, at the expense of
converting all date-only brithdays to the time 00:00:00. If support for
date-only birthdays is indeed required, the interface needs to be adjusted
or QDateTime needs to gain a date-only feature.

KOLAB: 3935

Conflicts:
	kabc/vcardtool.cpp


Diffs
-----

  src/vcardtool.cpp 49829af24411cc79262049c2a675759d73f7509c 

Diff: https://git.reviewboard.kde.org/r/123366/diff/


Testing
-------


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]