[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 123109: ETM: Turn assert into if(), this can happen when ETM is monitor
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2015-03-23 6:32:20
Message-ID: 20150323063220.18119.5621 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123109/#review77946
-----------------------------------------------------------

Ship it!


I'd prefer adding "&& !(!m_showRootCollection && collectionId == \
m_rootCollection.id())" to the if clause instead, but what you did with the comment \
works too.

- Christian Mollekopf


On March 22, 2015, 11:15 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123109/
> -----------------------------------------------------------
> 
> (Updated March 22, 2015, 11:15 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Christian Mollekopf.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Since 58af6d2ca8194, this sets it as the root of the model.
> So if the collection itself changes, the associated index is the invalid index.
> 
> 
> Diffs
> -----
> 
> akonadi/entitytreemodel_p.cpp 6800a8659e59b36472380d22968c341913a1a5bb 
> 
> Diff: https://git.reviewboard.kde.org/r/123109/diff/
> 
> 
> Testing
> -------
> 
> This was asserting, in the test app I'm writing, where the ETM is created with only \
> one specific collection to monitor. 
> 
> Thanks,
> 
> David Faure
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]