[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 122940: Patch to fix build on OSX 10.9
From:       René J.V. Bertin <rjvbertin () gmail ! com>
Date:       2015-03-15 14:44:43
Message-ID: 20150315144443.20027.59152 () mimi ! kde ! org
[Download RAW message or body]



> On March 15, 2015, 3:38 p.m., Allen Winter wrote:
> > Renee, how about matching the implementation signature in blogger.cpp, i.e. use \
> > the typedef in blogger.cpp as well.  else it will probably confuse doxygen or \
> > someone else later on who will decide to matchup the signatures.
> 
> Marko Käning wrote:
> Sound't like a good plan.
> 
> Talking about later... Where is this code in KF5 by now, Allen?

--e please, as I'm still male last I checked :P

No problem as far as I'm concerned to update blogger.cpp too. In fact it's surprising \
that this isn't necessary.

NB: my name is on this RR because I suggested the patch on a bug tracker, the \
reporter then reported back that it solved the build issue, and Marko then submitted \
the patch to RB. Credit where credit is due - I'm just the brains on this one, not \
the author ;)


- René J.V.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122940/#review77524
-----------------------------------------------------------


On March 14, 2015, 1:45 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122940/
> -----------------------------------------------------------
> 
> (Updated March 14, 2015, 1:45 p.m.)
> 
> 
> Review request for KDEPIM, Laurent Montel and René J.V. Bertin.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The MacPorts' ticket [#47087](http://trac.macports.org/ticket/47087) describes the \
> details and offers this patch. 
> * Has this code already made it into KF5?
> * And if so, which frameworks contains this code now? Does it still need fixing \
> there? 
> Thanks, René, for supplying the patch.
> 
> 
> Diffs
> -----
> 
> blogilo/src/blogger.h 9e9da5208d1f28d19c03c1e5d06f44dc3bafa3fe 
> 
> Diff: https://git.reviewboard.kde.org/r/122940/diff/
> 
> 
> Testing
> -------
> 
> Builds fine on MacPorts. Refer to above ticket.
> 
> 
> Thanks,
> 
> Marko Käning
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]