[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 122428: Move private methods/slots and slots from PersonsModel to Perso
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2015-02-06 12:32:52
Message-ID: 20150206123252.13234.56020 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122428/
-----------------------------------------------------------

(Updated Feb. 6, 2015, 12:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Telepathy.


Repository: libkpeople


Description
-------

Move the private methods into the p-impl. First, it's the correct thing to do. \
Secondly, it was pulling an awkward dependency on abstractcontact.h from the backends \
into a public header.


Diffs
-----

  src/CMakeLists.txt d8b4875 
  src/backends/abstractcontact.h 4d1edcd 
  src/personsmodel.h 239f4ed 
  src/personsmodel.cpp bc2bee6 

Diff: https://git.reviewboard.kde.org/r/122428/diff/


Testing
-------

Builds, tests pass, ktp-contactlist still works.


Thanks,

Aleix Pol Gonzalez

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]