--===============4031194369730793525==
Content-Type: multipart/signed; boundary="nextPart3964386.h6GUrjWjop"; micalg="pgp-sha1"; protocol="application/pgp-signature"


--nextPart3964386.h6GUrjWjop
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Sunday, December 14, 2014 12:42:36 PM Milian Wolff wrote:
> On Sunday 14 December 2014 12:29:25 Kevin Funk wrote:
> > Heya,
> >=20
> > Just got this from a user in #kde-devel: https://paste.kde.org/pxvu=
gaji8
> >=20
> > Note sure what the intended minimum required Qt version is here, bu=
t
> > either
> > way this needs to be fixed in the root CMakeLists.txt then.
> >=20
> > Caused by:
> >=20
> > commit 8a113985cda1693c8158916065bd54e57d028cda
> > Author: Milian Wolff <mail@milianw.de>
> > Date:   Mon Dec 1 11:39:33 2014 +0100
> >=20
> >     Use an QAtomicInt instead of a plain bool for Entity::cacheEnab=
led.
> >    =20
> >     A plain bool is not thread safe and leads to undefined behavior=
.
> >     So better be safe than sorry and use a thread safe QAtomicInt.
> >=20
> > ^ Needs http://doc.qt.io/qt-5/qatomicinteger.html#operator-int (sin=
ce 5.3)
>=20
> Note: I worked on this patch in Qt 4 Akonadi. I was not aware that th=
is
> breaks anything in Qt 5 master, which one could argue is due to a
> source-incompatible change then?

Sorry, I should have caught it during the review. I've run into this my=
self a=20
couple times, but I always forget about what pain QAtomicInt is...

> Anyhow, would be easy to fix, just add a .load().

Not that simple: we support Qt 5 build on 1.13 branch too, so we need t=
o fix=20
it there in cross-Qt compatible way. Qt 4 QAtomicInt does not have .loa=
d()=20
however, so this won't work. I guess we probably need to subclass QAtom=
icInt=20
and implement the overload ourselves by either providing operator int()=
 when=20
Qt >=3D 5.0 && Qt < 5.3, or provide .load() when Qt <  5.0.

On master we can just use .load() and .store() everywhere.

Dan

>=20
> Bye

=2D-=20
Daniel Vr=E1til | dvratil@redhat.com | dvratil on #kde-devel, #kontact,=
 #akonadi
Associate Software Engineer
KDE Desktop Team, Red Hat

GPG Key: 0xC59D614F6F4AE348                                            =
                                                                       =
                                                                      =20=

Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348    =20

--nextPart3964386.h6GUrjWjop
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABAgAGBQJUjsYFAAoJEMWdYU9vSuNIW18IAIyu9RhfDmLLVBE802y3k1Q7
clEBDWrsPFexZ+AgeeVA8Cde0Kpf/mW5rXTHbVHVgyYiismv3xcPayVUGP5QNaz8
9o/6J+lwn0R1EHBGPeFMJe5seO+02ZAlmAD5VXjBVwsPuUATmnYr7wr0Th+jn17K
oHlDTi4ZBIMOxOM2bfEZchmRwaXDwsqrNFE95ErJaMakRtqXGGS+fXFQeVpITRgf
TqylGL66ujW9LyXBWbpN/sOZ8c7UhOjOBwt0i2FALUoNf0nAXQ/PtQR3a44WmuwE
rvGiBqGBQcjGNp6Qc87EvqTtjLd4g9kaxQ9zBfEFqhIC5zrVs9AIWFwVslR9qbE=
=3gOJ
-----END PGP SIGNATURE-----

--nextPart3964386.h6GUrjWjop--


--===============4031194369730793525==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
--===============4031194369730793525==--