[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] FYI: Akonadi fails to compile on < Qt 5.3
From:       Milian Wolff <mail () milianw ! de>
Date:       2014-12-14 11:42:36
Message-ID: 4305344.W6ZSnSaJcX () minime
[Download RAW message or body]

On Sunday 14 December 2014 12:29:25 Kevin Funk wrote:
> Heya,
> 
> Just got this from a user in #kde-devel: https://paste.kde.org/pxvugaji8
> 
> Note sure what the intended minimum required Qt version is here, but either
> way this needs to be fixed in the root CMakeLists.txt then.
> 
> Caused by:
> 
> commit 8a113985cda1693c8158916065bd54e57d028cda
> Author: Milian Wolff <mail@milianw.de>
> Date:   Mon Dec 1 11:39:33 2014 +0100
> 
>     Use an QAtomicInt instead of a plain bool for Entity::cacheEnabled.
> 
>     A plain bool is not thread safe and leads to undefined behavior.
>     So better be safe than sorry and use a thread safe QAtomicInt.
> 
> ^ Needs http://doc.qt.io/qt-5/qatomicinteger.html#operator-int (since 5.3)

Note: I worked on this patch in Qt 4 Akonadi. I was not aware that this breaks 
anything in Qt 5 master, which one could argue is due to a source-incompatible 
change then?

Anyhow, would be easy to fix, just add a .load().

Bye
-- 
Milian Wolff
mail@milianw.de
http://milianw.de
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]