[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 121242: Coding Style for addressattribute.cpp emptytrashcommand.cpp mes
From:       "Guy Maurel" <guy-kde () maurel ! de>
Date:       2014-12-04 17:56:41
Message-ID: 20141204175641.22787.71041 () probe ! kde ! org
[Download RAW message or body]



> On Dec. 1, 2014, 1:09 p.m., Daniel Vrátil wrote:
> > akonadi-mime/src/standardmailactionmanager.cpp, line 187
> > <https://git.reviewboard.kde.org/r/121242/diff/1/?file=330652#file330652line187>
> > 
> > Please keep all i18n() methods in this whole switch statement with the same \
> > indentation. 
> > For instance this and the i18n call on l. 185 are indented differently, which \
> > makes it harder to read. 
> > Same applies on all the i18n changes below.

Well, the aligments were made with astyle.
Running astyle again will change it again.


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121242/#review71158
-----------------------------------------------------------


On Dec. 2, 2014, 4:50 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121242/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 4:50 p.m.)
> 
> 
> Review request for KDEPIM-Libraries, Daniel Vrátil, Kevin Krammer, Laurent Montel, \
> and Tobias Koenig. 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Details can be seen at:
> http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
> akonadi-mime/src/addressattribute.cpp c9d836b 
> akonadi-mime/src/emptytrashcommand.cpp 23ae88e 
> akonadi-mime/src/messagefolderattribute.cpp ad40353 
> akonadi-mime/src/messagemodel.cpp e4e2ca6 
> akonadi-mime/src/specialmailcollectionsrequestjob.cpp afdec8e 
> akonadi-mime/src/standardmailactionmanager.cpp \
> dda35b32f41ba786f3e3697d7d8e250860433e45  akonadi-mime/src/util.cpp d6404b8 
> akonadi-mime/src/messagestatus.cpp b9fa2fa 
> akonadi-mime/src/movetotrashcommand.cpp 5a641a0 
> akonadi-mime/src/removeduplicatesjob.cpp 239177b 
> akonadi-mime/src/specialmailcollections.cpp 1583e09 
> 
> Diff: https://git.reviewboard.kde.org/r/121242/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]