[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 121102: Move KMime::Codec to KCodecs framework, port KPimTextEdit to th
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2014-12-01 8:43:44
Message-ID: 20141201084344.22786.65224 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121102/#review71146
-----------------------------------------------------------

Ship it!


The best kind of patches are those with more code removed than added ;)

- Aaron J. Seigo


On Dec. 1, 2014, 7:59 a.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121102/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2014, 7:59 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This patch removes all KMime::Codec code from KMime, and moves it to KCodecs \
> framework (see /r/121047), where it will be more useful. KMime already depended on \
> KCodecs, so now it just depends on it on a few more places :) 
> This also ports KPimTextEdit away from KMime to KCodecs, as at depended on \
> KMime::Codec on couple places. 
> 
> Diffs
> -----
> 
> kmime/CMakeLists.txt 8294f5e 
> kmime/autotests/CMakeLists.txt 665bbc9 
> kmime/autotests/base64benchmark.cpp 4c743df 
> kmime/autotests/codectest.h 197f937 
> kmime/autotests/codectest.cpp 55a79a7 
> kmime/src/CMakeLists.txt 790ea70 
> kmime/src/kmime_codec_base64.h ef52f7f 
> kmime/src/kmime_codec_base64.cpp c9434a5 
> kmime/src/kmime_codec_identity.h 934cf8e 
> kmime/src/kmime_codec_identity.cpp c418394 
> kmime/src/kmime_codec_qp.h c80cebd 
> kmime/src/kmime_codec_qp.cpp 10a9a74 
> kmime/src/kmime_codec_uuencode.h cfca864 
> kmime/src/kmime_codec_uuencode.cpp 4706bcb 
> kmime/src/kmime_codecs.h 47b1d74 
> kmime/src/kmime_codecs.cpp b9f5a6f 
> kmime/src/kmime_content.cpp 78a5368 
> kmime/src/kmime_header_parsing.cpp c04bd5d 
> kmime/src/kmime_headers.cpp eb42d9b 
> kmime/src/kmime_util.cpp 6b7ef37 
> kpimtextedit/CMakeLists.txt 2609e1c 
> kpimtextedit/autotests/CMakeLists.txt e43d8ef 
> kpimtextedit/autotests/textedittest.cpp b71ab96 
> kpimtextedit/src/CMakeLists.txt c55f002 
> kpimtextedit/src/textedit.cpp c127f35 
> 
> Diff: https://git.reviewboard.kde.org/r/121102/diff/
> 
> 
> Testing
> -------
> 
> KMime tests pass, KPimTextEdit tests pass
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]