[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 120527: ItemSync/TransactionSquence: Don't abort on error
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2014-10-10 16:40:35
Message-ID: 20141010164035.10359.74285 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120527/
-----------------------------------------------------------

(Updated Oct. 10, 2014, 4:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries, David Faure and Dan Vrátil.


Repository: kdepimlibs


Description
-------

ItemSync/TransactionSquence: Don't abort on error

The ItemSync must never emit result before it's complete. This patch fixes
this behvaiour in case of an error on the ItemCreateJob.

* Adding a job does not reset the status if a rollback was initiated already,
and thus avoids a second rollback on commit() after one was already performed
earlier (this resulted in the "No transaction in progress" error message).
* The rollback job, that is equally added using addSubjob still gets regularly
executed.


Diffs
-----

  akonadi/tests/itemsynctest.cpp d0b7cee6c4ad3766ad9bb5c6219af5752514511d 
  akonadi/transactionsequence.cpp 2d6bb7b430ee0b9c004ef02224ec7792a7116370 

Diff: https://git.reviewboard.kde.org/r/120527/diff/


Testing
-------

Seems to work for me, unittests.


Thanks,

Christian Mollekopf

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]