[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 119933: Optimize: Share set of \SEEN flag across items.
From:       "Kevin Ottens" <ervin () kde ! org>
Date:       2014-08-28 7:35:29
Message-ID: 20140828073529.11204.98978 () probe ! kde ! org
[Download RAW message or body]



> On Aug. 28, 2014, 6:38 a.m., David Faure wrote:
> > i think MSVC doesn't implement threadsafe-statics yet.
> > Maybe ifndef msvc static endif, then?
> > Looks good otherwise.

IIRC, VS14 should but it's not out yet.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119933/#review65395
-----------------------------------------------------------


On Aug. 27, 2014, 7:24 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119933/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 7:24 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and David Faure.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Most items just have a single \SEEN flag in their list of flags.
> Currently, we share the \SEEN flag, but not the list itself. By
> special-casing this extremely often occurring case, we can decrease
> the memory consumption easily. In my case it's a difference of ca.
> 7MB (171MB before vs. 164MB after).
> 
> 
> Diffs
> -----
> 
> akonadi/protocolhelper.cpp 3d496667fa622cac2dda7d5a0ca4c92b5a59d2fe 
> 
> Diff: https://git.reviewboard.kde.org/r/119933/diff/
> 
> 
> Testing
> -------
> 
> ran it before and after this patch and compared the memory consumption. That went \
> down noticeably. Also added a static counter to compare cache hits/misses \
> temporarily, which showed this cache is easily hit ca. 40k times and only missed 4k \
> times (so a 10:1 ratio, not bad at all :)) 
> 
> Thanks,
> 
> Milian Wolff
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]