[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 119746: Allow FavoriteCollectionsModel to be reset when Akonadi server 
From:       "David Jarvie" <djarvie () kde ! org>
Date:       2014-08-12 22:28:32
Message-ID: 20140812222832.14667.77726 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119746/
-----------------------------------------------------------

(Updated Aug. 12, 2014, 10:28 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Bugs: 336942
    http://bugs.kde.org/show_bug.cgi?id=336942


Repository: kdepimlibs


Description
-------

When the Akonadi server stops, calling \
FavoriteCollectionsModel::setCollections(Collection::List()) removes all collections \
from the model's collection list, but no collections are removed from the list of \
referenced collections. This is because the private dereference() function only \
removes them if their model index is valid. But because the server has stopped, they \
cannot have valid indexes.

The patch makes dereference() remove the collection from the list of referenced \
collections regardless of whether the collection's model index is valid. This allows \
FavoriteCollectionsModel to be reset completely when the server has stopped.


Diffs
-----

  akonadi/favoritecollectionsmodel.cpp 08b1975 

Diff: https://git.reviewboard.kde.org/r/119746/diff/


Testing
-------

Tested with KAlarm. This now allows alarms to be redisplayed after an Akonadi server \
restart.


Thanks,

David Jarvie

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]