[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Akonadi: updated coding style
From:       Daniel Vratil <dvratil () redhat ! com>
Date:       2014-08-01 9:12:57
Message-ID: 2735063.rVZuD7y6Ck () thor
[Download RAW message or body]

On Thursday 31 of July 2014 18:08:17 Kevin Ottens wrote:
> Hello,
> =

> On Thursday 31 July 2014 14:06:56 Daniel Vr=E1til wrote:
> > I just merged Guy's coding-style branch in Akonadi git to master, which
> > means that in Akonadi we now follow the new KDE PIM coding style [0], l=
ike
> > we already do in kdepimlibs/akonadi.
> > =

> > I want to say big thank you to Guy for his work - it's an incredible
> > amount
> > of code he had to go through and fix and thanks to him we now have a
> > reasonable coding style which is also consistent with most of the KDE
> > projects.
> =

> Note however that it introduced some behavior change. The patch is just
> insanely big so it'll be hard to spot *where* it is, but I got some of my
> tests depending on knut which started to fail after this update. See my
> struggle there:
> http://build.kde.org/job/zanshin_master/
> =

> I thought it was one of my own commits, but I finally nailed it down to t=
hat
> coding style commit. If I revert it locally my tests pass again.
> =

> I found a workaround for the time being (I'll CC you Dan on it), but that
> might require being investigated.

Hi Kevin,

I found the problems and fixed them in git master. Could you please try =

whether your Zanshin tests now pass without the workaround?

Thanks,
Dan

> =

> Regards.

-- =

Daniel Vr=E1til | dvratil@redhat.com | dvratil on #kde-devel, #kontact, #ak=
onadi
KDE Desktop Team
Associate Software Engineer, Red Hat

GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]