[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 119127: Outline for reply and forward
From:       "Michael Bohlender" <michael.bohlender () kdemail ! net>
Date:       2014-07-05 11:46:26
Message-ID: 20140705114626.2609.38876 () probe ! kde ! org
[Download RAW message or body]



> On July 5, 2014, 10:58 a.m., Kevin Krammer wrote:
> > mobile/api/mail/composer.h, line 91
> > <https://git.reviewboard.kde.org/r/119127/diff/1/?file=287328#file287328line91>
> > 
> > Hmm. I don't think these are operations in Composer.
> > A composer will be opened as a result of them, no?

like we discussed in the meeting. make them  void replyTo( akonadiURL ).


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119127/#review61638
-----------------------------------------------------------


On July 5, 2014, 10:46 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119127/
> -----------------------------------------------------------
> 
> (Updated July 5, 2014, 10:46 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Outline for Adding the identity, replyTo, forward to the composer file. It didn't \
> seem to compile until I added kdepim in the cmakelists.txt and messagecomposer/ in \
> the header. I want to know whether this approach is right of using kdepim identity \
> and message factory? For now I am using a test createplaintextmessage(), which has \
> to be replaced by akonadi item.  
> 
> Diffs
> -----
> 
> messagecore/misc/mdnstateattribute.h c609665 
> mobile/api/mail/CMakeLists.txt bc1aebe 
> mobile/api/mail/composer.h b731287 
> mobile/api/mail/composer.cpp dc750e8 
> 
> Diff: https://git.reviewboard.kde.org/r/119127/diff/
> 
> 
> Testing
> -------
> 
> Yet to be done.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]