[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 119080: fix timezone config in calendar view
From: "David Jarvie" <djarvie () kde ! org>
Date: 2014-07-02 10:16:21
Message-ID: 20140702101621.22318.33564 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119080/#review61471
-----------------------------------------------------------
calendarviews/agenda/timescaleconfigdialog.cpp
<https://git.reviewboard.kde.org/r/119080/#comment42786>
Just a nitpick: should be tzWithoutUtc() - without is a single word in English.
- David Jarvie
On July 2, 2014, 5:38 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119080/
> -----------------------------------------------------------
>
> (Updated July 2, 2014, 5:38 a.m.)
>
>
> Review request for KDEPIM and Sergio Luis Martins.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> old implementation uses i18n string in return value, which will make timezone \
> configuration not working for other language, this commit uses Qt::UserRole to \
> store the timezone name information.
>
> Diffs
> -----
>
> calendarviews/agenda/timescaleconfigdialog.cpp 2dbe3e0
>
> Diff: https://git.reviewboard.kde.org/r/119080/diff/
>
>
> Testing
> -------
>
> change timezone under zh_CN now works.
>
>
> Thanks,
>
> Xuetian Weng
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic