[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 118103: tag modifications (e.g. rename) are not propagated through TagM
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2014-05-13 10:25:46
Message-ID: 20140513102546.377.93156 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118103/
-----------------------------------------------------------

(Updated May 13, 2014, 10:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

I've been trying to implement a tag renaming operation, using an \
Akonadi::TagModifyJob.  This appears to work, and the change propagates to the \
Akonadi::TagModel where TagModelPrivate::monitoredTagChanged() gets called as \
intended.

There appears to be a problem here, though, in the usual case where the tag is not \
being reparented.  The mTags hash is updated, but the mChildTags list for the parent \
is not.  This means that TagModel::data(), which fetches the tag from the mChildTags \
hash using tagForIndex(), still returns the old data value and the change appears to \
have no effect.


Diffs
-----

  akonadi/tagmodel_p.cpp 0f6d5bb 

Diff: https://git.reviewboard.kde.org/r/118103/diff/


Testing
-------

Built kdepimlibs with this change, tested tag modification - the change is propagated \
correctly.


Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]