[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request 117993: Stop needlessly calling KDirWatch::stopScan().
From:       "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date:       2014-05-04 22:57:07
Message-ID: 20140504225707.20771.31997 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117993/
-----------------------------------------------------------

Review request for KDEPIM, David Faure and Laurent Montel.


Repository: kdepim


Description
-------

Not only should the call be unnecessary, but it also causes an infinite
loop when KDirWatch is set to use QFileSystemWatcher: the
KDirWatch::stopScan()/addDir()/startScan() combination makes the slot
where they're called end up being infinitely triggered.


Diffs
-----

  grantleetheme/grantleethememanager.cpp 09e95f55f077d5cee94f2a63dfa5b1042e65091c 
  pimcommon/templatewidgets/templatemanager.cpp a0678e8e537d55a824acb2a5911674340708a24c 

Diff: https://git.reviewboard.kde.org/r/117993/diff/


Testing
-------

KMail is usable with QFileSystemWatcher.


Thanks,

Raphael Kubo da Costa

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]