[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 117834: kaddressbook: add a category (tag) display filter
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2014-05-02 20:19:39
Message-ID: 20140502201939.16222.3799 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117834/
-----------------------------------------------------------

(Updated May 2, 2014, 8:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM.


Bugs: 332103
    http://bugs.kde.org/show_bug.cgi?id=332103


Repository: kdepim


Description
-------

There is currently no GUI to select or filter contacts by categories (tags).  Apart \
from the unituitive workaround of typing the tag name in the quick filter box (which \
doesn't work well with post-Baloo contacts which store the contact's categories as an \
Akonadi URL instead of the name).

This change adds a list of currently defined categories to the main layout, with \
additional entries for "all" and special categories.  The contacts list is filtered \
by checked categories in this list.  To avoid confusion, there is no filtering in \
simple (1-column) mode or if the category list is hidden.  The context menu over this \
list has quick options to check or clear all of the categories.


Diffs
-----

  kaddressbook/categoryselectwidget.h PRE-CREATION 
  kaddressbook/categoryfilterproxymodel.cpp PRE-CREATION 
  kaddressbook/categoryfilterproxymodel.h PRE-CREATION 
  kaddressbook/CMakeLists.txt a22e731 
  kaddressbook/categoryselectwidget.cpp PRE-CREATION 
  kaddressbook/kaddressbookui.rc 6f4a774 
  kaddressbook/mainwidget.h 0075edf 
  kaddressbook/mainwidget.cpp 804a5f0 
  kaddressbook/settings/kaddressbook.kcfg f3a3e38 

Diff: https://git.reviewboard.kde.org/r/117834/diff/


Testing
-------

Built kaddressbook with this change, tested on my personal address book (several \
hundred entries and approximately 20 category tags).


File Attachments
----------------

Screen shot 1
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/28/37775637-78da-425f-85a4-a22b5ca52d9c__kaddressbook-categoryfilter_1.png
 Screen shot 2
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/28/0189e057-9250-40f6-aefd-d0ed2ea5be65__kaddressbook-categoryfilter_2.png
  Screen shot for r2 - filter in quick search bar 
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/01/34908029-098a-40d9-a1b9-eadfbf71a734__kaddressbook-categoryfilter_3.png



Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]