[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 117642: Fixes MailWebView::scrollToAnchor
From:       "Lindsay Mathieson" <lindsay.mathieson () gmail ! com>
Date:       2014-04-20 9:12:52
Message-ID: 20140420091252.3533.43366 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117642/
-----------------------------------------------------------

(Updated April 20, 2014, 9:12 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM.


Bugs: 333619
    http://bugs.kde.org/show_bug.cgi?id=333619


Repository: kdepim


Description
-------

The DOM code in MailWebView::scrollToAnchor no longer seems to work. However there is \
a QT api call in QWebFrame::scrollToAnchor() introduced in QT 4.7 that implements the \
functionality needed.


Diffs
-----

  messageviewer/viewer/mailwebview_webkit.cpp d39345b 

Diff: https://git.reviewboard.kde.org/r/117642/diff/


Testing
-------

Built, installed and tested with HTML messages that have links to inline Anchors in \
their body. The messages scrolled to display the anchor position as expected.


File Attachments
----------------

Email Msg with inline links
  https://git.reviewboard.kde.org/media/uploaded/files/2014/04/20/a310d3d5-fbc5-4574-92d2-9cdf7ae75642__freecycle_brisbane_Recent_Posts_on_Brisbane.mbox



Thanks,

Lindsay Mathieson

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]