From kde-pim Sun Apr 13 22:28:13 2014 From: "David Jarvie" Date: Sun, 13 Apr 2014 22:28:13 +0000 To: kde-pim Subject: Re: [Kde-pim] Review Request 117237: Coding Style for job_p.h Message-Id: X-MARC-Message: https://marc.info/?l=kde-pim&m=139742812106570 On Sun, April 13, 2014 7:20 pm, Kevin Krammer wrote: > On Friday, 2014-04-04, 15:46:19, Guy Maurel wrote: >> > On March 31, 2014, 10:34 p.m., David Jarvie wrote: >> > > When there was a flood of coding style review requests 3 or 4 weeks >> ago, >> > > you were requested to group multiple files into single reviews. Once >> > > again, there are lots of reviews all for individual files, which >> > > creates too many emails on the list. >> As I make a review I must deal with my reviewer(s). >> Kevin and Dan wish a review per file. Please, discuss that with the >> reviewers. Thanks. > > My preference is reviews I an quickly go through, i.e. each review only > takes > a couple of minutes and not half an hour. > > If anyone else prefers huge reviews make sure you are actually [1] > volunteering to do the reviews because I won't. How about grouping the reviews into say 3 or 4 files per review? This would substantially reduce the traffic on the mailing list, and might be manageable from your point of view also? -- David Jarvie. KDE developer. KAlarm author - http://www.astrojar.org.uk/kalarm _______________________________________________ KDE PIM mailing list kde-pim@kde.org https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/