'Re: [Kde-pim] Review Request 116985: mbox: make "compact now" working when file is already empty'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 116985: mbox: make "compact now" working when file is already empty
From:       "Laurent Montel" <montel () kde ! org>
Date:       2014-03-31 21:00:23
Message-ID: 20140331210023.20888.49191 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116985/#review54721
-----------------------------------------------------------

resources/mbox/compactpage.cpp
<https://git.reviewboard.kde.org/r/116985/#comment38233>

    const QString fileName = ...

- Laurent Montel

On March 22, 2014, 9:41 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116985/
> -----------------------------------------------------------
> 
> (Updated March 22, 2014, 9:41 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> It often happens that my mbox file is definitely empty, e.g. because I removed it \
> or emptied it with an external program. In these cases the mbox resource can still \
> not be compacted as the MBox::purge() returns false to notify that it could not \
> remove the given deleted items (which does not matter if the file is already \
> empty). 
> This patch checks that even if purge() returns false but the file is already empty, \
> we still discard our deleted items list and do not issue an error.
> 
> 
> Diffs
> -----
> 
> resources/mbox/compactpage.cpp f78782c 
> 
> Diff: https://git.reviewboard.kde.org/r/116985/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread] 