[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 117140: ItemSync: Only fetch the items that are actually required.
From:       Dan_Vrátil <dvratil () redhat ! com>
Date:       2014-03-28 19:17:57
Message-ID: 20140328191757.10710.92266 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117140/#review54492
-----------------------------------------------------------

Ship it!


Remove the unneeded change and ship it. Remember to fix coding style when merging to master.

- Dan Vrátil


On March 28, 2014, 6:26 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117140/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 6:26 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> ItemSync: Only fetch the items that are actually required.
> 
> ItemSync used to fetch *all* items during *every* sync, which is in most cases
> completely unnecessary (at least for incremental sync). This patch delays the
> fetch of items until we know which ones we need, and then only fetches the
> required ones (usually none), resulting in an IMAP sync going from 10s 100%,
> to a couple of seconds 1% cpu.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemsync.cpp 05ee3d04a5b94c85abcab27ebc638e57b6a63d41 
> 
> Diff: https://git.reviewboard.kde.org/r/117140/diff/
> 
> 
> Testing
> -------
> 
> Running it locally, unittest passes.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]