From kde-pim  Sat Mar 22 21:41:06 2014
From: "Martin Koller" <kollix () aon ! at>
Date: Sat, 22 Mar 2014 21:41:06 +0000
To: kde-pim
Subject: [Kde-pim] Review Request 116985: mbox: make "compact now" working when file is already empty
Message-Id: <20140322214106.21519.82040 () probe ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-pim&m=139552449625388


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116985/
-----------------------------------------------------------

Review request for KDEPIM and Kevin Krammer.


Repository: kdepim-runtime


Description
-------

It often happens that my mbox file is definitely empty, e.g. because I removed it or emptied it with an external program.
In these cases the mbox resource can still not be compacted as the MBox::purge() returns false to notify that it could
not remove the given deleted items (which does not matter if the file is already empty).

This patch checks that even if purge() returns false but the file is already empty, we still discard our deleted items list
and do not issue an error.


Diffs
-----

  resources/mbox/compactpage.cpp f78782c 

Diff: https://git.reviewboard.kde.org/r/116985/diff/


Testing
-------

yes


Thanks,

Martin Koller

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/