[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 116933: avoid splitting an UTF-8 encoded character in the middle of the
From: "Kevin Krammer" <krammer () kde ! org>
Date: 2014-03-22 10:23:11
Message-ID: 20140322102311.13655.7500 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116933/#review53734
-----------------------------------------------------------
Ship it!
Only a tiny style thing left. Push when it is fixed.
Also check spacing in parentheses after merging into master, i.e. if the base file \
has already been adapted to the new coding style
kabc/vcardparser/vcardparser.cpp
<https://git.reviewboard.kde.org/r/116933/#comment37679>
style: else onto previous line
- Kevin Krammer
On March 21, 2014, 4:56 p.m., Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116933/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 4:56 p.m.)
>
>
> Review request for KDEPIM-Libraries and Kevin Krammer.
>
>
> Bugs: 271859
> http://bugs.kde.org/show_bug.cgi?id=271859
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> the file format spec in RFC 6350 says:
> http://tools.ietf.org/html/rfc6350#section-3.2
> Line Delimiting and Folding
>
> "Multi-octet characters MUST remain contiguous."
>
> The current implementation would split anywhere.
>
> My solution checks for UTF-8 encoding and moves only full encoding sequences to the \
> next line.
>
> Diffs
> -----
>
> kabc/vcardparser/testroundtrip.qrc e5a6616
> kabc/vcardparser/vcardparser.cpp ec8f272
>
> Diff: https://git.reviewboard.kde.org/r/116933/diff/
>
>
> Testing
> -------
>
> added a new vcard testcase for the roundtrip test.
> tested also manually with different line lengths
>
>
> Thanks,
>
> Martin Koller
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic