From kde-pim  Wed Mar 19 12:31:12 2014
From: "David Jarvie" <djarvie () kde ! org>
Date: Wed, 19 Mar 2014 12:31:12 +0000
To: kde-pim
Subject: Re: [Kde-pim] Review Request 116877: Make ItemFetchJob work for in Item whose remote ID is specified
Message-Id: <20140319123112.10295.53822 () probe ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-pim&m=139523231401065


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116877/
-----------------------------------------------------------

(Updated March 19, 2014, 12:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM-Libraries.


Repository: kdepimlibs


Description
-------

Currently when an Item with only remote ID specified is supplied to the ItemFetchJob constructor, calling setCollection() to set its context does not (contrary to the apidox) work. In fact, setCollection() only works when fetching whole Collections, for which a separate constructor is provided. This patch makes setCollection(), and fetching by remote ID, work the way they are supposed to.


Diffs
-----

  akonadi/itemfetchjob.cpp 93168c3 

Diff: https://git.reviewboard.kde.org/r/116877/diff/


Testing
-------

Tested with new KAlarm code.


Thanks,

David Jarvie

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/