[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 116877: Make ItemFetchJob work for in Item whose remote ID is specified
From:       Dan_Vrátil <dvratil () redhat ! com>
Date:       2014-03-19 11:23:40
Message-ID: 20140319112340.10295.50203 () probe ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116877/#review53409
-----------------------------------------------------------

Ship it!


Looks OK. Thanks.

In the long run I'd like to get rid of the SELECT command completely and instead \
specify the collection in a FETCH command argument to speed up item fetch a little.

- Dan Vrátil


On March 19, 2014, 12:17 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116877/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 12:17 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Currently when an Item with only remote ID specified is supplied to the \
> ItemFetchJob constructor, calling setCollection() to set its context does not \
> (contrary to the apidox) work. In fact, setCollection() only works when fetching \
> whole Collections, for which a separate constructor is provided. This patch makes \
> setCollection(), and fetching by remote ID, work the way they are supposed to. 
> 
> Diffs
> -----
> 
> akonadi/itemfetchjob.cpp 93168c3 
> 
> Diff: https://git.reviewboard.kde.org/r/116877/diff/
> 
> 
> Testing
> -------
> 
> Tested with new KAlarm code.
> 
> 
> Thanks,
> 
> David Jarvie
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]