[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 113486: Correctly fetch and expose METADATA annotations
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2013-11-05 15:15:01
Message-ID: 20131105151501.19560.3396 () vidsolbach ! de
[Download RAW message or body]



> On Nov. 5, 2013, 3:04 p.m., Kevin Ottens wrote:
> > I guess that's a first review for further work, any chance to consolidate tests \
> > with this review? I'd expect the introduction of automated tests which fail \
> > without the content of this diff.

Well, I hoped to get around it =P
IMO the whole ANNOTATEMORE/METADATA differentiation should be hidden by kimap, and I \
want to get that fixed together with proper support for shared/private namespaces. \
Therefore I'd like to also test this in kimap as it is really a protocol thing that \
just leaks to the proxy atm. If you deem it important enough to have tests now I'll \
write them though.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113486/#review43067
-----------------------------------------------------------


On Nov. 5, 2013, 2:56 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113486/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2013, 2:56 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Ottens.
> 
> 
> Bugs: 301154 and 313159
> http://bugs.kde.org/show_bug.cgi?id=301154
> http://bugs.kde.org/show_bug.cgi?id=313159
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> This diff contains two related patches to get METADATA annotations working.
> 
> ---
> Get METADATA annotations.
> 
> METADATA doesn't allow a wildcard as entry specifier.
> 
> BUG: 313159
> 
> ---
> 
> Translate annotations from METADATA to ANNOTATEMORE style.
> 
> The IMAP proxy and the collectionannotationsattribute currently only
> support shared annotations.
> To match what kmail and the kolabproxy expect, we translate all METADATA
> annotations (/shared/vendor/...) to ANNOTATEMORE (/vendor/....) and back
> when writing.
> 
> BUG: 301154
> 
> 
> Diffs
> -----
> 
> resources/imap/addcollectiontask.cpp 07f7bfb 
> resources/imap/changecollectiontask.cpp a0acd84 
> resources/imap/retrievecollectionmetadatatask.cpp 2dd3b97 
> 
> Diff: http://git.reviewboard.kde.org/r/113486/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]