[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 113252: Extract messages from javascript wizards
From: "Allen Winter" <winter () kde ! org>
Date: 2013-10-16 22:35:45
Message-ID: 20131016223545.8229.1274 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113252/#review41849
-----------------------------------------------------------
yes, will be ok for master but I'd like to have a min version of kdelibs 4.11.3 added \
to the top-level CMakeLists.txt as well
- Allen Winter
On Oct. 14, 2013, 10:29 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113252/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2013, 10:29 p.m.)
>
>
> Review request for KDEPIM.
>
>
> Repository: kdepim-runtime
>
>
> Description
> -------
>
> Translate the javascript files used in the wizards that were not translated before.
> I was going to commit this directly (as it does not impact the code, and it fixes a \
> long-standing issue), but this change depends on a kdelibs patch which has been \
> committed today (https://git.reviewboard.kde.org/r/113218/), which means kdelibs \
> 4.11.3. The code in this review adds some calls to qsTr(), and when that kdelibs \
> patch is not applied the wizard scripts exit with a run time error (and a blank \
> window). So the code in this review adds an implicit dependency on kdelibs 4.11.3; \
> the cmake code says "kdelibs 4.10, kdepimlibs 4.11". Would it be acceptable?
>
> Diffs
> -----
>
> accountwizard/wizards/tine20/Messages.sh 30a1fec
> accountwizard/wizards/tine20/tine20wizard.es 6970b1d
> resources/imap/wizard/Messages.sh 8fbc16c
> resources/imap/wizard/imapwizard.es dcab06f
> resources/kolabproxy/wizard/Messages.sh 5654648
> resources/kolabproxy/wizard/kolabwizard.es 842e757
> resources/maildir/wizard/Messages.sh 69bb8e9
> resources/maildir/wizard/maildirwizard.es af61f8a
> resources/mbox/wizard/Messages.sh d720fde
> resources/mbox/wizard/mailboxwizard.es 286d4c0
> resources/pop3/wizard/Messages.sh fee8e77
> resources/pop3/wizard/pop3wizard.js 47262e4
>
> Diff: http://git.reviewboard.kde.org/r/113252/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luigi Toscano
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic