[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 113221: FindQGpgme: Be more silent when looking for Gpgme.
From:       "Allen Winter" <winter () kde ! org>
Date:       2013-10-12 23:09:18
Message-ID: 20131012230918.11273.32268 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113221/#review41619
-----------------------------------------------------------

Ship it!


I agree with this for sure in a FindFoo.cmake

- Allen Winter


On Oct. 12, 2013, 6:46 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113221/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2013, 6:46 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> FindQGpgme: Be more silent when looking for Gpgme.
> 
> The fact that FindQGpgme looks for Gpgme itself should be transparent to
> users. Additionally, if QUIET is not passed to the find_package() call CMake
> will output duplicate messages if the user also calls find_package(Gpgme).
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQGpgme.cmake 0355ebe2b095b3d1204b6dde91f1016a6e62c225 
> 
> Diff: http://git.reviewboard.kde.org/r/113221/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]