[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 112968: kmail: improve the layout of the Composer - General tab
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2013-10-07 12:56:53
Message-ID: 20131007125653.12188.78526 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112968/
-----------------------------------------------------------

(Updated Oct. 7, 2013, 12:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDEPIM and Allen Winter.


Repository: kdepim


Description
-------

The "Configure KMail - Composer - General" dialogue tab has probably been much added \
to over time, and now resembles the aftermath of an explosion in a checkbox factory.  \
None of the spin boxes or buttons near the bottom line up, and there is inconsistent \
punctuation.

This revised layout uses group boxes to split the options up into categories, and \
lines up the buttons and spin boxes using grid layouts internal to the group boxes.  \
All widgets have a tool top and what's this text - most useful for some of the more \
obscure options, e.g. the new "Improve plain text..." option.

The layout works for both the normal and enterprise builds (see the two "after" \
screen shots).


Diffs
-----

  kmail/configuredialog/configuredialog.cpp 81d50c4 
  kmail/settings/kmail.kcfg.cmake e620fc2 
  messagecomposer/settings/messagecomposer.kcfg.cmake 2c0b3e6 

Diff: http://git.reviewboard.kde.org/r/112968/diff/


Testing
-------

Built kmail with these changes.  Checked appearance, layout and operation of all \
buttons.


File Attachments
----------------

Screen shot - before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/27/kmail-composerproperties-before.png
 Screen shot - after, normal build
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/27/kmail-composerproperties-after-normal.png
 Screen shot - after, enterprise build
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/27/kmail-composerproperties-after-enterprise.png



Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]