'Re: [Kde-pim] Review Request 112864: kaddressbook: display all of the contact's IM addresses'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 112864: kaddressbook: display all of the contact's IM addresses
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2013-09-24 13:52:16
Message-ID: 20130924135216.20716.1862 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112864/
-----------------------------------------------------------

(Updated Sept. 24, 2013, 1:52 p.m.)

Review request for KDEPIM.

Changes
-------

D'oh!

Description
-------

If a contact has multiple IM addresses defined, only the one set as standard (or the \
first one if this has not been done) are displayed.  There is also no indication of \
the protocol to which this applies.

With this change, all of the IM addresses are shown with their protocol and icon.  It \
requires the header file and symbol export at \
https://git.reviewboard.kde.org/r/112844/ to be applied to kdepimlibs in order to \
compile kdepim, so intended for the master branch only.

This change was originally suggested for the standard contact formatter at \
https://git.reviewboard.kde.org/r/108837/.  There was some discussion on that with \
the KTelepathy people and the conclusion was that making these clickable within \
KAddressBook was not really a useful thing to do.  So the data is displayed only - \
the text can still be copied if necessary.

Diffs (updated)
-----

  kaddressbook/viewertemplates/contact_embedded.html 233366c 
  kaddressbookgrantlee/formatter/grantleecontactformatter.cpp 1129e31 

Diff: http://git.reviewboard.kde.org/r/112864/diff/

Testing
-------

Built kaddressbook with these changes, checked contact display.

File Attachments
----------------

All contact IM addresses displayed
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/21/kaddressbook-imdisplay_B1.png
 The full repertoire
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/21/kaddressbook-imdisplay_B2.png

Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread] 