[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request 112844: make IMProtocols class exported and install header
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2013-09-20 16:03:38
Message-ID: 20130920160338.32374.65507 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112844/
-----------------------------------------------------------

Review request for KDEPIM-Libraries.


Description
-------

Although information on the supported IM protocols (name and icon) is available via \
the classes in akonadi/contact/editor/im, tne header file improtocols.h is not \
installed and the library symbols are not exported from libakonadi-contact.

This means that they cannot be accessed outside of that part of kdepimlibs.  \
Specifically, since the Grantlee-based kaddressbook contact formatting is now in \
kdepim (the standard formatting was in kdepimlibs), it is not possible to access the \
IM information from there.  It would be useful to display all the contact's IM \
addresses in the same way as suggested on https://git.reviewboard.kde.org/r/108837/, \
although the consensus on that review was that making them clickable was not \
currently useful - so the intention is to display them only.  Implementing this in \
the Grantlee formatter require access to the IMProtocols class from outside \
libakonadi-contact.

This change installs one header file and makes the class accessible outside the \
library.  It should be BC according to \
http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++


Diffs
-----

  akonadi/contact/CMakeLists.txt b0672dd 
  akonadi/contact/editor/im/improtocols.h 217e984 

Diff: http://git.reviewboard.kde.org/r/112844/diff/


Testing
-------

Built kdepimlibs with this change, checked installation of header file and that the \
symbols are exported (using nm).


Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]