[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 112801: contact editor: make label buddy shortcuts work for all fields
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2013-09-19 10:45:54
Message-ID: 20130919104554.30278.84332 () vidsolbach ! de
[Download RAW message or body]



> On Sept. 18, 2013, 7:55 p.m., Allen Winter wrote:
> > Looks good.  Also thanks for adding the KUIT.
> > 
> > I'm not 100% happy with variable names like 'l' and 'hb', but otherwise feel free \
> > to commit.

Variable names made longer, thanks for spotting that one local variable was redundant \
(another defined a few lines down).


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112801/#review40302
-----------------------------------------------------------


On Sept. 19, 2013, 10:42 a.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112801/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 10:42 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Description
> -------
> 
> Although most of the field labels in the contact editor have buddy widgets set (to \
> the appropriate entry field) and show an Alt+letter shortcut, some of them do not \
> work when that is pressed because the custom widgets do not have a focus \
> proxy/policy.  This change corrects that for the pages and fields: 
> Contact: Name, Display, Email, Messaging
> 
> Business: Free/Busy
> 
> Personal: Birthdate, Anniversary
> 
> Location: Address combo
> 
> For the address type combo in the "Location" tab, and the same combo in the address \
> edit dialogue, a label is placed before it so that it can have an accelerator to \
> focus the combo box.  Screen shots are attached. 
> With these changes (plus 33ec1c35 to kdepimlibs and 7964a6d1 to kdepim for the \
> "Crypto settings" plugin) , all contact editor fields can be activated or given \
> focus using Alt+letter shortcuts.  Well, apart from "Office" under "Business", \
> where there are no available accelerators to be assigned :-( 
> 
> Diffs
> -----
> 
> akonadi/contact/editor/addresseditwidget.cpp ead62a5 
> akonadi/contact/editor/dateeditwidget.cpp 0056154 
> akonadi/contact/editor/displaynameeditwidget.cpp 6bd0b43 
> akonadi/contact/editor/emaileditwidget.cpp d1e30ba 
> akonadi/contact/editor/freebusyeditwidget.cpp 5ae27a5 
> akonadi/contact/editor/imeditwidget.cpp cda7895 
> akonadi/contact/editor/nameeditwidget.cpp 9d6dd50 
> 
> Diff: http://git.reviewboard.kde.org/r/112801/diff/
> 
> 
> Testing
> -------
> 
> Build kdepimlibs with these changes.  Checked action of all underlined accelerators \
> in kaddressbook contact editor dialogue. 
> 
> File Attachments
> ----------------
> 
> Contact editor "Location" tab
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/18/kaddressbook-editor-buddies_1.png
>  Address edit dialogue
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/18/kaddressbook-editor-buddies_2.png
>  
> 
> Thanks,
> 
> Jonathan Marten
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]