[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 112734: Fix renaming of IMAP folders on server with separator other tha
From:       "Andras Mantia" <amantia () kde ! org>
Date:       2013-09-15 19:17:18
Message-ID: 20130915191718.9980.35515 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112734/#review40081
-----------------------------------------------------------


It seems ok, jus be sure to test that it doesn't introduce a regression for the fix here \
http://git.reviewboard.kde.org/r/109276/ (point 1). (Yes, that fix needs an improvement.)

- Andras Mantia


On Sept. 15, 2013, 10:33 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112734/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2013, 10:33 a.m.)
> 
> 
> Review request for KDEPIM and Kevin Ottens.
> 
> 
> Description
> -------
> 
> ResourceTask::separatorCharacter() is giving up too easily when parent collection is not \
> available (which happens with ChangeCollectionTask for instance) and just falls back to "/" \
> separator. In cases like ChangeCollectionTask however, we can get the separator from remoteId \
> of the current collection. 
> This fixes renaming of subfolders on servers that use for instance "." as a separator.
> 
> 
> This addresses bug 324219.
> http://bugs.kde.org/show_bug.cgi?id=324219
> 
> 
> Diffs
> -----
> 
> resources/imap/resourcetask.cpp f63e986 
> 
> Diff: http://git.reviewboard.kde.org/r/112734/diff/
> 
> 
> Testing
> -------
> 
> Successfully renamed a folder on a server which is using "." separator. Since \
> separatorCharacter() is reimplemented in ResourceState, it cannot be properly unittested \
> (tests use DummyResourceState with custom simplified implementation) 
> 
> Thanks,
> 
> Dan Vrátil
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]