[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request 112743: kaddressbook: make Grantlee contact display consistent with previou
From:       "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date:       2013-09-15 14:33:04
Message-ID: 20130915143304.21293.84088 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112743/
-----------------------------------------------------------

Review request for KDEPIM.


Description
-------

This change implements the display layout improvements, previously implemented for \
the "standard" contact display, to the new contact display using Grantlee templates.  \
Specifically:

Action icons are lined up vertically, and are used for SMS and address display.  This \
is as originally implemented on https://git.reviewboard.kde.org/r/108719/

The original logic to display the job title or rôle is used.  That is, the second \
line of the display is the first non-empty value from:

  1.  contact.title()
  2.  contact.role()
  3.  contact.custom("X-Profession")

This code was previously in StandardContactFormatter::toHtml() in \
kdepimlibs/akonadi/contact/standardcontactformatter.cpp


Diffs
-----

  kaddressbook/grantlee/grantleecontactformatter.cpp 0c61276 
  kaddressbook/viewertemplates/contact_embedded.html 640e32c 
  kaddressbook/viewertemplates/contact_row.html 18f598f 

Diff: http://git.reviewboard.kde.org/r/112743/diff/


Testing
-------

Built kaddressbook with these changes, observed display of contacts.


File Attachments
----------------

Screenshot before
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/15/grantlee-before.png
Screenshot after
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/15/grantlee-after.png


Thanks,

Jonathan Marten

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]