[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 112130: Implements session restore
From:       "Lindsay Mathieson" <lindsay.mathieson () gmail ! com>
Date:       2013-08-18 3:26:00
Message-ID: 20130818032600.24355.69379 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112130/
-----------------------------------------------------------

(Updated Aug. 18, 2013, 1:25 p.m.)


Review request for KDEPIM and Lindsay Mathieson.


Changes
-------

Style fixes.


Description
-------

Adds:
- Session restore
- Saving of MainWindow geometry and visible state
- Toggling of visibility by clicking SysTrayIcon.
- Splash screen is not shown when restoring session.

Internal behaviour change. To enable preservation of state when the session is being \
saved, the MainWindow is no longer closed and deleted when minimising to the system \
tray, rather it is hidden.


This addresses bug 309461.
    http://bugs.kde.org/show_bug.cgi?id=309461


Diffs (updated)
-----

  kleopatra/kleopatraapplication.h 202c937 
  kleopatra/kleopatraapplication.cpp 91c07cf 
  kleopatra/main.cpp 572242d 
  kleopatra/mainwindow_desktop.h d02f6c4 
  kleopatra/mainwindow_desktop.cpp 55efd91 
  kleopatra/systrayicon.h 2621985 
  kleopatra/systrayicon.cpp 5a5cd2e 

Diff: http://git.reviewboard.kde.org/r/112130/diff/


Testing
-------

- Start kleopatra. 
* Log out/in, the MainWindow will be restored to its previous screen position.

- Start kleopatra, minimise window to tray. 
* Log out/in, the MainWindow will be restored to the tray. Click the tray icon and \
the MainWindow will be restored to its previous screen position. 

- Start Kmail. 
  * Choose "Tools|Certificate Manager". kleopatra will be started.
  * Click on a signature thumprint in a signed message. The kleopatra key search or \
detail dilaog will be displayed.


- Start kleopatra
- Start Kmail. 
  * Choose "Tools|Certificate Manager". kleopatra will be displayed.
  * Click on a signature thumbprint in a signed message. The kleopatra key search or \
detail dialog will be displayed.


Thanks,

Lindsay Mathieson

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic