[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 107179: Use IMAP standard flags for replied messages
From:       "Christian Mollekopf" <chrigi_1 () fastmail ! fm>
Date:       2013-08-16 10:01:20
Message-ID: 20130816100120.8505.87970 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107179/#review37942
-----------------------------------------------------------


I think what akoandi/kmime/messageflags.h specifies an akonadi specific set of \
message flags, and it is the resources responsibility to translate the flag to one \
with the same semantics available for the backend. By chance the flags chosen are the \
same as IMAP, but they could really be anything. The IMAP resource already translates \
Akonadi::MessageFlags::Answered to the IMAP version, and I don't know why we have \
Akonadi::MessageFlags::Replied at all as that seems to represent the same.

IMO we can apply this patch and should then deprecate Akonadi::MessageFlags::Replied \
and replace it's use by Akonadi::MessageFlags::Answered everywhere. I'd still like a \
confirmation of kevin, volker or or whoever else knows if I understood this \
correctly.

- Christian Mollekopf


On Nov. 2, 2012, 4:55 p.m., Chuso Perez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107179/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2012, 4:55 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> (c&p) kmail2 uses it's own IMAP flags. Instead of RFC2060 compliant flags, like eg \
> "\Answered", it uses "$REPLIED". That throws off other clients, e.g. Hastymail ² \
> webmailer which then cannot display the message status properly. 
> 
> This addresses bug 291332.
> http://bugs.kde.org/show_bug.cgi?id=291332
> 
> 
> Diffs
> -----
> 
> agents/maildispatcher/sentactionhandler.cpp 59dee37 
> resources/maildir/libmaildir/maildir.cpp b6bb579 
> 
> Diff: http://git.reviewboard.kde.org/r/107179/diff/
> 
> 
> Testing
> -------
> 
> I've tested it for several months and it seems that fixes the reported bug with my \
> coworkers with apparently no side effects. 
> 
> Thanks,
> 
> Chuso Perez
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]