[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 112008: Fix cmake checks for Grantlee dependency
From:       "David Jarvie" <djarvie () kde ! org>
Date:       2013-08-11 13:43:25
Message-ID: 20130811134325.4864.5332 () vidsolbach ! de
[Download RAW message or body]



> On Aug. 11, 2013, 8:10 a.m., Laurent Montel wrote:
> > messageviewer/grantleefilters/CMakeLists.txt, line 11
> > <http://git.reviewboard.kde.org/r/112008/diff/1/?file=177981#file177981line11>
> > 
> > ? you make hard requires and you use it ?
> > so your check is not good too.
> > If you do it you must to make it in other place but if you need it it's that your \
> > check is not good.

Because grantlee_add_plugin is only defined by the grantlee package, it needs to be \
surrounded by the 'if(Grantlee_FOUND)' conditional, or else cmake fails immediately \
and doesn't report that grantlee package is required but missing (which I have \
explained in the comments above that line). If you don't like this, then how else can \
we ensure that cmake completes properly if grantlee is missing?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112008/#review37496
-----------------------------------------------------------


On Aug. 11, 2013, 1:43 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112008/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2013, 1:43 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> If Grantlee is not found or is too old, cmake fails abruptly in \
> messageviewer/grantleefilters/CMakeLists.txt due to missing cmake definitions, and \
> does not inform the user that Grantlee is required or what version or Grantlee is \
> required. The patch encloses this cmake code in a conditional to allow cmake to run \
> to completion and display a list of missing REQUIRED packages. 
> Since Grantlee is now a hard dependency, the QUIET keyword is also removed from the \
> Grantlee find_package() call.,  
> 
> Diffs
> -----
> 
> messageviewer/grantleefilters/CMakeLists.txt 276d7c7 
> 
> Diff: http://git.reviewboard.kde.org/r/112008/diff/
> 
> 
> Testing
> -------
> 
> cmake was run with Grantlee missing, at version 0.1.4 and version 0.3.0. The first \
> two cases list Grantlee in the missing REQUIRED packages at the end of cmake's run, \
> while in the last case cmake succeeds. 
> 
> Thanks,
> 
> David Jarvie
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]